[PATCH] D31167: Use FPContractModeKind universally

[Yaxun Liu via Phabricator via cfe-commits]

yaxunl added inline comments.


================
Comment at: cfe/trunk/lib/Frontend/CompilerInvocation.cpp:1638
     Opts.LaxVectorConversions = 0;
-    Opts.DefaultFPContract = 1;
+    Opts.setDefaultFPContractMode(LangOptions::FPC_On);
     Opts.NativeHalfType = 1;
----------------
hfinkel wrote:
> yaxunl wrote:
> > hfinkel wrote:
> > > Looks like the intent is certainly to have kept the OpenCL default the same here.
> > Well we also use clang to compile LLVM IR to ISA. Before this change, fp-contract was on so that backend did fp contract. However, now clang does not turn on fp-contract when compiling LLVM IRs.
> That's the equivalent of 'Fast'. Maybe this should also be set to Fast then.
Agree. That should fix this issue.


Repository:
  rL LLVM

https://reviews.llvm.org/D31167