[PATCH] D31167: Use FPContractModeKind universally

Hal Finkel via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Apr 10 13:03:41 PDT 2017


hfinkel added inline comments.


================
Comment at: cfe/trunk/lib/Frontend/CompilerInvocation.cpp:1638
     Opts.LaxVectorConversions = 0;
-    Opts.DefaultFPContract = 1;
+    Opts.setDefaultFPContractMode(LangOptions::FPC_On);
     Opts.NativeHalfType = 1;
----------------
yaxunl wrote:
> hfinkel wrote:
> > Looks like the intent is certainly to have kept the OpenCL default the same here.
> Well we also use clang to compile LLVM IR to ISA. Before this change, fp-contract was on so that backend did fp contract. However, now clang does not turn on fp-contract when compiling LLVM IRs.
That's the equivalent of 'Fast'. Maybe this should also be set to Fast then.


Repository:
  rL LLVM

https://reviews.llvm.org/D31167





More information about the cfe-commits mailing list