[PATCH] D30388: [XRay] Add -fxray-{always, never}-instrument= flags to clang

[Reid Kleckner via Phabricator via cfe-commits]

rnk added inline comments.


================
Comment at: lib/Basic/XRayFunctionFilter.cpp:21
+    : AlwaysInstrument(
+          llvm::SpecialCaseList::createOrDie(AlwaysInstrumentPaths)),
+      NeverInstrument(llvm::SpecialCaseList::createOrDie(NeverInstrumentPaths)),
----------------
Hm, phab ate my comment about this. I don't think we should use this API in clang. Instead, we should use the `::create(...)` version and issue a diagnostic similar to err_drv_malformed_sanitizer_blacklist from the caller of this function.


https://reviews.llvm.org/D30388