[PATCH] D30388: [XRay] Add -fxray-{always, never}-instrument= flags to clang

Reid Kleckner via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Mar 22 10:52:48 PDT 2017


rnk added a comment.

I think you need some driver logic to make sure the xray lists show up in .d files so that modifications to them trigger rebuilds in most build systems. See the SanitizerArgs.cpp driver logic for this.



================
Comment at: include/clang/Basic/XRayFunctionFilter.h:1
+//===--- XRayFunctionFilter.h - XRay automatic-attribution ------*- C++ -*-===//
+//
----------------
Do you think XRayLists.h might be a better name for this header? It's analagous to SanitizerBlacklist.h, but it's not a "black" list.


https://reviews.llvm.org/D30388





More information about the cfe-commits mailing list