r296221 - [ODRHash] Move inherited visitor call to end of function.

Richard Trieu via cfe-commits cfe-commits at lists.llvm.org
Tue Feb 28 14:31:18 PST 2017


There's no functional change.  This was a mistake I made when splitting the
original patch into pieces and I wanted to correct before proceeding with
additional changes.

On Mon, Feb 27, 2017 at 8:27 AM, David Blaikie <dblaikie at gmail.com> wrote:

> An explanation as to why the code was moved (& possibly test cases, or
> "NFC" in the description) would be handy here.
>
> On Fri, Feb 24, 2017 at 5:41 PM Richard Trieu via cfe-commits <
> cfe-commits at lists.llvm.org> wrote:
>
>> Author: rtrieu
>> Date: Fri Feb 24 19:29:34 2017
>> New Revision: 296221
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=296221&view=rev
>> Log:
>> [ODRHash] Move inherited visitor call to end of function.
>>
>> Modified:
>>     cfe/trunk/lib/AST/ODRHash.cpp
>>
>> Modified: cfe/trunk/lib/AST/ODRHash.cpp
>> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/AST/
>> ODRHash.cpp?rev=296221&r1=296220&r2=296221&view=diff
>> ============================================================
>> ==================
>> --- cfe/trunk/lib/AST/ODRHash.cpp (original)
>> +++ cfe/trunk/lib/AST/ODRHash.cpp Fri Feb 24 19:29:34 2017
>> @@ -182,8 +182,6 @@ public:
>>    }
>>
>>    void VisitFieldDecl(const FieldDecl *D) {
>> -    Inherited::VisitFieldDecl(D);
>> -
>>      const bool IsBitfield = D->isBitField();
>>      Hash.AddBoolean(IsBitfield);
>>
>> @@ -193,6 +191,8 @@ public:
>>
>>      Hash.AddBoolean(D->isMutable());
>>      AddStmt(D->getInClassInitializer());
>> +
>> +    Inherited::VisitFieldDecl(D);
>>    }
>>  };
>>
>>
>>
>> _______________________________________________
>> cfe-commits mailing list
>> cfe-commits at lists.llvm.org
>> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20170228/e00e3459/attachment-0001.html>


More information about the cfe-commits mailing list