<div dir="ltr">There's no functional change.  This was a mistake I made when splitting the original patch into pieces and I wanted to correct before proceeding with additional changes.</div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Feb 27, 2017 at 8:27 AM, David Blaikie <span dir="ltr"><<a href="mailto:dblaikie@gmail.com" target="_blank">dblaikie@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">An explanation as to why the code was moved (& possibly test cases, or "NFC" in the description) would be handy here.</div><div class="HOEnZb"><div class="h5"><br><div class="gmail_quote"><div dir="ltr">On Fri, Feb 24, 2017 at 5:41 PM Richard Trieu via cfe-commits <<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: rtrieu<br class="m_7286731749663661267gmail_msg">
Date: Fri Feb 24 19:29:34 2017<br class="m_7286731749663661267gmail_msg">
New Revision: 296221<br class="m_7286731749663661267gmail_msg">
<br class="m_7286731749663661267gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=296221&view=rev" rel="noreferrer" class="m_7286731749663661267gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project?rev=296221&view=rev</a><br class="m_7286731749663661267gmail_msg">
Log:<br class="m_7286731749663661267gmail_msg">
[ODRHash] Move inherited visitor call to end of function.<br class="m_7286731749663661267gmail_msg">
<br class="m_7286731749663661267gmail_msg">
Modified:<br class="m_7286731749663661267gmail_msg">
    cfe/trunk/lib/AST/ODRHash.cpp<br class="m_7286731749663661267gmail_msg">
<br class="m_7286731749663661267gmail_msg">
Modified: cfe/trunk/lib/AST/ODRHash.cpp<br class="m_7286731749663661267gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/AST/ODRHash.cpp?rev=296221&r1=296220&r2=296221&view=diff" rel="noreferrer" class="m_7286731749663661267gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/cfe/trunk/lib/AST/<wbr>ODRHash.cpp?rev=296221&r1=<wbr>296220&r2=296221&view=diff</a><br class="m_7286731749663661267gmail_msg">
==============================<wbr>==============================<wbr>==================<br class="m_7286731749663661267gmail_msg">
--- cfe/trunk/lib/AST/ODRHash.cpp (original)<br class="m_7286731749663661267gmail_msg">
+++ cfe/trunk/lib/AST/ODRHash.cpp Fri Feb 24 19:29:34 2017<br class="m_7286731749663661267gmail_msg">
@@ -182,8 +182,6 @@ public:<br class="m_7286731749663661267gmail_msg">
   }<br class="m_7286731749663661267gmail_msg">
<br class="m_7286731749663661267gmail_msg">
   void VisitFieldDecl(const FieldDecl *D) {<br class="m_7286731749663661267gmail_msg">
-    Inherited::VisitFieldDecl(D);<br class="m_7286731749663661267gmail_msg">
-<br class="m_7286731749663661267gmail_msg">
     const bool IsBitfield = D->isBitField();<br class="m_7286731749663661267gmail_msg">
     Hash.AddBoolean(IsBitfield);<br class="m_7286731749663661267gmail_msg">
<br class="m_7286731749663661267gmail_msg">
@@ -193,6 +191,8 @@ public:<br class="m_7286731749663661267gmail_msg">
<br class="m_7286731749663661267gmail_msg">
     Hash.AddBoolean(D->isMutable(<wbr>));<br class="m_7286731749663661267gmail_msg">
     AddStmt(D-><wbr>getInClassInitializer());<br class="m_7286731749663661267gmail_msg">
+<br class="m_7286731749663661267gmail_msg">
+    Inherited::VisitFieldDecl(D);<br class="m_7286731749663661267gmail_msg">
   }<br class="m_7286731749663661267gmail_msg">
 };<br class="m_7286731749663661267gmail_msg">
<br class="m_7286731749663661267gmail_msg">
<br class="m_7286731749663661267gmail_msg">
<br class="m_7286731749663661267gmail_msg">
______________________________<wbr>_________________<br class="m_7286731749663661267gmail_msg">
cfe-commits mailing list<br class="m_7286731749663661267gmail_msg">
<a href="mailto:cfe-commits@lists.llvm.org" class="m_7286731749663661267gmail_msg" target="_blank">cfe-commits@lists.llvm.org</a><br class="m_7286731749663661267gmail_msg">
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" class="m_7286731749663661267gmail_msg" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/cfe-commits</a><br class="m_7286731749663661267gmail_msg">
</blockquote></div>
</div></div></blockquote></div><br></div>