[PATCH] D30157: [analyzer] Improve valist check

Daniel Marjamäki via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Feb 24 03:26:51 PST 2017


danielmarjamaki added inline comments.


================
Comment at: lib/StaticAnalyzer/Checkers/ValistChecker.cpp:189
+  const auto *EReg = dyn_cast_or_null<ElementRegion>(Reg);
+  return EReg && VaListModelledAsArray ? EReg->getSuperRegion() : Reg;
+}
----------------
I would personally recommend parentheses around EReg and VaListModelledAsArray to highlight the precedence.



https://reviews.llvm.org/D30157





More information about the cfe-commits mailing list