[PATCH] D30157: [analyzer] Improve valist check
Gábor Horváth via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Feb 21 05:49:25 PST 2017
xazax.hun added inline comments.
================
Comment at: test/Analysis/valist-uninitialized-no-undef.c:19
+ // FIXME: There should be no warning for this.
+ (void)va_arg(*fst, int); // expected-warning{{va_arg() is called on an uninitialized va_list}} expected-note{{va_arg() is called on an uninitialized va_list}}
+ va_end(*fst);
----------------
xazax.hun wrote:
> NoQ wrote:
> > As the patch tries to handle symbolic va_list regions, i wonder what's so particularly hard about this false positive (apart from its being obviously rare, by the way did you actually see such code?).
> What is strange, this case does work with the hexagon AST variant.
Also, I did not see such code inproduction yet
https://reviews.llvm.org/D30157
More information about the cfe-commits
mailing list