[PATCH] D29469: Fix PR31843: Clang-4.0 crashes/assert while evaluating __builtin_object_size

[Mehdi AMINI via Phabricator via cfe-commits]

mehdi_amini added a comment.

>   My concern with that approach is that we'd just end up playing whack-a-bug. It's possible that this fix puts us in a similar situation, but I'm honestly at a loss for a better approach. ¯\_(ツ)_/¯ (...And I'd kinda prefer to play whack-a-bug with "clang could do a better job in this case" reports, rather than "clang crashes on my code" reports.)

Agree, thanks :)

This patch LGTM but I have little confidence in myself in this area of the compiler, so I rather have someone else stamping it!


https://reviews.llvm.org/D29469