[PATCH] D20561: Warn when taking address of packed member

Roger Ferrer Ibanez via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Feb 1 03:24:38 PST 2017


rogfer01 added a comment.

In https://reviews.llvm.org/D20561#662922, @royger wrote:

>


Hi,

some targets do not support unaligned accesses so this warning is valuable in terms of portability. In platforms where unaligned accesses are allowed, it may happen that such accesses incur in a performance penalty. So there is also value in terms of performance.

We fixed all identified false positives in later patches to this one. So maybe you want to check against trunk clang. If trunk still diagnoses false positives, please report them to me and I will be more than happy to fix them.

Kind regards.


Repository:
  rL LLVM

https://reviews.llvm.org/D20561





More information about the cfe-commits mailing list