[PATCH] D20561: Warn when taking address of packed member

[Roger via Phabricator via cfe-commits]

royger reopened this revision.
royger added a comment.
This revision is now accepted and ready to land.

Hello,

This addition is silly, and too noisy for real world usage.

For once, it doesn't really check whether the access is actually unaligned or not, and then on x86 for example unaligned accesses are allowed (although with a performance penalty). Please either make this only complain about real unaligned accesses, or remove it. I don't think it's going to be used by any real-world projects, since it's too noise and gives false positives.


Repository:
  rL LLVM

https://reviews.llvm.org/D20561