r293457 - Tidy up codegen modules test & make it x86 specific since it relies on Itanium name manglings

[Robinson, Paul via cfe-commits]

Okay as is, then.  Thanks for the explanation.
--paulr

From: David Blaikie [mailto:dblaikie at gmail.com]
Sent: Monday, January 30, 2017 9:32 AM
To: Robinson, Paul
Cc: cfe-commits (cfe-commits at lists.llvm.org)
Subject: Re: r293457 - Tidy up codegen modules test & make it x86 specific since it relies on Itanium name manglings

On reflection itanium wouldn't be sufficient/my comment wasn't sufficiently descriptive (I realized after I made this change that it would also fix the MacOS buildbot failure I was seeing & hadn't understood) - Darwin doesn't use comdats, for example, but is still an itanium ABI.

I could remove the checks for comdats - but I think they're beneficial/relevant.

Could refactor them to be optional somehow, but not sure it's worth it?

On Mon, Jan 30, 2017 at 9:28 AM Robinson, Paul <paul.robinson at sony.com<mailto:paul.robinson at sony.com>> wrote:
Use %itanium_abi_triple instead?

> -----Original Message-----
> From: cfe-commits [mailto:cfe-commits-bounces at lists.llvm.org<mailto:cfe-commits-bounces at lists.llvm.org>] On Behalf Of
> David Blaikie via cfe-commits
> Sent: Sunday, January 29, 2017 9:34 PM
> To: cfe-commits at lists.llvm.org<mailto:cfe-commits at lists.llvm.org>
> Subject: r293457 - Tidy up codegen modules test & make it x86 specific
> since it relies on Itanium name manglings
>
> Author: dblaikie
> Date: Sun Jan 29 23:33:51 2017
> New Revision: 293457
>
> URL: http://llvm.org/viewvc/llvm-project?rev=293457&view=rev
> Log:
> Tidy up codegen modules test & make it x86 specific since it relies on
> Itanium name manglings
>
> Modified:
>     cfe/trunk/test/Modules/codegen.test
>
> Modified: cfe/trunk/test/Modules/codegen.test
> URL: http://llvm.org/viewvc/llvm-
> project/cfe/trunk/test/Modules/codegen.test?rev=293457&r1=293456&r2=293457
> &view=diff
> ==========================================================================
> ====
> --- cfe/trunk/test/Modules/codegen.test (original)
> +++ cfe/trunk/test/Modules/codegen.test Sun Jan 29 23:33:51 2017
> @@ -1,15 +1,16 @@
>  RUN: rm -rf %t
> +REQUIRES: x86-registered-target
>
> -RUN: %clang_cc1 -fmodules-codegen -x c++ -fmodules -emit-module -fmodule-
> name=foo %S/Inputs/codegen/foo.modulemap -o %t/foo.pcm
> -RUN: %clang_cc1 -fmodules-codegen -x c++ -fmodules -emit-module -fmodule-
> name=bar %S/Inputs/codegen/bar.modulemap -o %t/bar.pcm -fmodule-
> file=%t/foo.pcm
> +RUN: %clang_cc1 -triple=x86_64-linux-gnu -fmodules-codegen -x c++ -
> fmodules -emit-module -fmodule-name=foo %S/Inputs/codegen/foo.modulemap -o
> %t/foo.pcm
> +RUN: %clang_cc1 -triple=x86_64-linux-gnu -fmodules-codegen -x c++ -
> fmodules -emit-module -fmodule-name=bar %S/Inputs/codegen/bar.modulemap -o
> %t/bar.pcm -fmodule-file=%t/foo.pcm
>
> -RUN: %clang_cc1 -emit-llvm %t/foo.pcm -o - | FileCheck --check-prefix=FOO
> %s
> -RUN: %clang_cc1 -emit-llvm %t/bar.pcm -o - -fmodule-file=%t/foo.pcm |
> FileCheck --check-prefix=BAR-CMN --check-prefix=BAR %s
> -RUN: %clang_cc1 -fmodules -fmodule-file=%t/foo.pcm -fmodule-
> file=%t/bar.pcm %S/Inputs/codegen/use.cpp -emit-llvm -o - | FileCheck --
> check-prefix=USE-CMN --check-prefix=USE %s
> +RUN: %clang_cc1 -triple x86_64-linux-gnu -emit-llvm -o - %t/foo.pcm |
> FileCheck --check-prefix=FOO %s
> +RUN: %clang_cc1 -triple x86_64-linux-gnu -emit-llvm -o - %t/bar.pcm -
> fmodule-file=%t/foo.pcm | FileCheck --check-prefix=BAR-CMN --check-
> prefix=BAR %s
> +RUN: %clang_cc1 -triple x86_64-linux-gnu -emit-llvm -o - -fmodules -
> fmodule-file=%t/foo.pcm -fmodule-file=%t/bar.pcm %S/Inputs/codegen/use.cpp
> | FileCheck --check-prefix=USE-CMN --check-prefix=USE %s
>
> -RUN: %clang_cc1 -O2 -disable-llvm-passes -emit-llvm %t/foo.pcm -o - |
> FileCheck --check-prefix=FOO %s
> -RUN: %clang_cc1 -O2 -disable-llvm-passes -emit-llvm %t/bar.pcm -o - -
> fmodule-file=%t/foo.pcm | FileCheck --check-prefix=BAR-CMN --check-
> prefix=BAR-OPT %s
> -RUN: %clang_cc1 -O2 -disable-llvm-passes -fmodules -fmodule-
> file=%t/foo.pcm -fmodule-file=%t/bar.pcm %S/Inputs/codegen/use.cpp -emit-
> llvm -o - | FileCheck --check-prefix=USE-CMN --check-prefix=USE-OPT %s
> +RUN: %clang_cc1 -triple x86_64-linux-gnu -emit-llvm -o - -O2 -disable-
> llvm-passes %t/foo.pcm | FileCheck --check-prefix=FOO %s
> +RUN: %clang_cc1 -triple x86_64-linux-gnu -emit-llvm -o - -O2 -disable-
> llvm-passes %t/bar.pcm -fmodule-file=%t/foo.pcm | FileCheck --check-
> prefix=BAR-CMN --check-prefix=BAR-OPT %s
> +RUN: %clang_cc1 -triple x86_64-linux-gnu -emit-llvm -o - -O2 -disable-
> llvm-passes -fmodules -fmodule-file=%t/foo.pcm -fmodule-file=%t/bar.pcm
> %S/Inputs/codegen/use.cpp | FileCheck --check-prefix=USE-CMN --check-
> prefix=USE-OPT %s
>
>  FOO-NOT: comdat
>  FOO: $_Z3foov = comdat any
>
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at lists.llvm.org<mailto:cfe-commits at lists.llvm.org>
> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20170130/23d07016/attachment-0001.html>