<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="Generator" content="Microsoft Word 14 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Tahoma;
panose-1:2 11 6 4 3 5 4 4 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman","serif";}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
span.EmailStyle17
{mso-style-type:personal-reply;
font-family:"Calibri","sans-serif";
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri","sans-serif";}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-US" link="blue" vlink="purple">
<div class="WordSection1">
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">Okay as is, then. Thanks for the explanation.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">--paulr<o:p></o:p></span></p>
<p class="MsoNormal"><a name="_MailEndCompose"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p> </o:p></span></a></p>
<div style="border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt">
<div>
<div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">From:</span></b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif""> David Blaikie [mailto:dblaikie@gmail.com]
<br>
<b>Sent:</b> Monday, January 30, 2017 9:32 AM<br>
<b>To:</b> Robinson, Paul<br>
<b>Cc:</b> cfe-commits (cfe-commits@lists.llvm.org)<br>
<b>Subject:</b> Re: r293457 - Tidy up codegen modules test & make it x86 specific since it relies on Itanium name manglings<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<p class="MsoNormal">On reflection itanium wouldn't be sufficient/my comment wasn't sufficiently descriptive (I realized after I made this change that it would also fix the MacOS buildbot failure I was seeing & hadn't understood) - Darwin doesn't use comdats,
for example, but is still an itanium ABI.<br>
<br>
I could remove the checks for comdats - but I think they're beneficial/relevant.<br>
<br>
Could refactor them to be optional somehow, but not sure it's worth it?<o:p></o:p></p>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<div>
<p class="MsoNormal">On Mon, Jan 30, 2017 at 9:28 AM Robinson, Paul <<a href="mailto:paul.robinson@sony.com">paul.robinson@sony.com</a>> wrote:<o:p></o:p></p>
</div>
<blockquote style="border:none;border-left:solid #CCCCCC 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-right:0in">
<p class="MsoNormal">Use %itanium_abi_triple instead?<br>
<br>
> -----Original Message-----<br>
> From: cfe-commits [mailto:<a href="mailto:cfe-commits-bounces@lists.llvm.org" target="_blank">cfe-commits-bounces@lists.llvm.org</a>] On Behalf Of<br>
> David Blaikie via cfe-commits<br>
> Sent: Sunday, January 29, 2017 9:34 PM<br>
> To: <a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a><br>
> Subject: r293457 - Tidy up codegen modules test & make it x86 specific<br>
> since it relies on Itanium name manglings<br>
><br>
> Author: dblaikie<br>
> Date: Sun Jan 29 23:33:51 2017<br>
> New Revision: 293457<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=293457&view=rev" target="_blank">
http://llvm.org/viewvc/llvm-project?rev=293457&view=rev</a><br>
> Log:<br>
> Tidy up codegen modules test & make it x86 specific since it relies on<br>
> Itanium name manglings<br>
><br>
> Modified:<br>
> cfe/trunk/test/Modules/codegen.test<br>
><br>
> Modified: cfe/trunk/test/Modules/codegen.test<br>
> URL: <a href="http://llvm.org/viewvc/llvm-" target="_blank">http://llvm.org/viewvc/llvm-</a><br>
> project/cfe/trunk/test/Modules/codegen.test?rev=293457&r1=293456&r2=293457<br>
> &view=diff<br>
> ==========================================================================<br>
> ====<br>
> --- cfe/trunk/test/Modules/codegen.test (original)<br>
> +++ cfe/trunk/test/Modules/codegen.test Sun Jan 29 23:33:51 2017<br>
> @@ -1,15 +1,16 @@<br>
> RUN: rm -rf %t<br>
> +REQUIRES: x86-registered-target<br>
><br>
> -RUN: %clang_cc1 -fmodules-codegen -x c++ -fmodules -emit-module -fmodule-<br>
> name=foo %S/Inputs/codegen/foo.modulemap -o %t/foo.pcm<br>
> -RUN: %clang_cc1 -fmodules-codegen -x c++ -fmodules -emit-module -fmodule-<br>
> name=bar %S/Inputs/codegen/bar.modulemap -o %t/bar.pcm -fmodule-<br>
> file=%t/foo.pcm<br>
> +RUN: %clang_cc1 -triple=x86_64-linux-gnu -fmodules-codegen -x c++ -<br>
> fmodules -emit-module -fmodule-name=foo %S/Inputs/codegen/foo.modulemap -o<br>
> %t/foo.pcm<br>
> +RUN: %clang_cc1 -triple=x86_64-linux-gnu -fmodules-codegen -x c++ -<br>
> fmodules -emit-module -fmodule-name=bar %S/Inputs/codegen/bar.modulemap -o<br>
> %t/bar.pcm -fmodule-file=%t/foo.pcm<br>
><br>
> -RUN: %clang_cc1 -emit-llvm %t/foo.pcm -o - | FileCheck --check-prefix=FOO<br>
> %s<br>
> -RUN: %clang_cc1 -emit-llvm %t/bar.pcm -o - -fmodule-file=%t/foo.pcm |<br>
> FileCheck --check-prefix=BAR-CMN --check-prefix=BAR %s<br>
> -RUN: %clang_cc1 -fmodules -fmodule-file=%t/foo.pcm -fmodule-<br>
> file=%t/bar.pcm %S/Inputs/codegen/use.cpp -emit-llvm -o - | FileCheck --<br>
> check-prefix=USE-CMN --check-prefix=USE %s<br>
> +RUN: %clang_cc1 -triple x86_64-linux-gnu -emit-llvm -o - %t/foo.pcm |<br>
> FileCheck --check-prefix=FOO %s<br>
> +RUN: %clang_cc1 -triple x86_64-linux-gnu -emit-llvm -o - %t/bar.pcm -<br>
> fmodule-file=%t/foo.pcm | FileCheck --check-prefix=BAR-CMN --check-<br>
> prefix=BAR %s<br>
> +RUN: %clang_cc1 -triple x86_64-linux-gnu -emit-llvm -o - -fmodules -<br>
> fmodule-file=%t/foo.pcm -fmodule-file=%t/bar.pcm %S/Inputs/codegen/use.cpp<br>
> | FileCheck --check-prefix=USE-CMN --check-prefix=USE %s<br>
><br>
> -RUN: %clang_cc1 -O2 -disable-llvm-passes -emit-llvm %t/foo.pcm -o - |<br>
> FileCheck --check-prefix=FOO %s<br>
> -RUN: %clang_cc1 -O2 -disable-llvm-passes -emit-llvm %t/bar.pcm -o - -<br>
> fmodule-file=%t/foo.pcm | FileCheck --check-prefix=BAR-CMN --check-<br>
> prefix=BAR-OPT %s<br>
> -RUN: %clang_cc1 -O2 -disable-llvm-passes -fmodules -fmodule-<br>
> file=%t/foo.pcm -fmodule-file=%t/bar.pcm %S/Inputs/codegen/use.cpp -emit-<br>
> llvm -o - | FileCheck --check-prefix=USE-CMN --check-prefix=USE-OPT %s<br>
> +RUN: %clang_cc1 -triple x86_64-linux-gnu -emit-llvm -o - -O2 -disable-<br>
> llvm-passes %t/foo.pcm | FileCheck --check-prefix=FOO %s<br>
> +RUN: %clang_cc1 -triple x86_64-linux-gnu -emit-llvm -o - -O2 -disable-<br>
> llvm-passes %t/bar.pcm -fmodule-file=%t/foo.pcm | FileCheck --check-<br>
> prefix=BAR-CMN --check-prefix=BAR-OPT %s<br>
> +RUN: %clang_cc1 -triple x86_64-linux-gnu -emit-llvm -o - -O2 -disable-<br>
> llvm-passes -fmodules -fmodule-file=%t/foo.pcm -fmodule-file=%t/bar.pcm<br>
> %S/Inputs/codegen/use.cpp | FileCheck --check-prefix=USE-CMN --check-<br>
> prefix=USE-OPT %s<br>
><br>
> FOO-NOT: comdat<br>
> FOO: $_Z3foov = comdat any<br>
><br>
><br>
> _______________________________________________<br>
> cfe-commits mailing list<br>
> <a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a><br>
> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" target="_blank">
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><o:p></o:p></p>
</blockquote>
</div>
</div>
</div>
</body>
</html>