[PATCH] D28223: clean up use of _WIN32

[Kim Gräsman via Phabricator via cfe-commits]

kimgr added a comment.

@smeenai I think I tried to make a jumbled mess of points :-)

1. Associating an encoding with a char/element type seems wrong; any number of encodings can use wchar_t.
2. Windows allegedly uses UTF-16 now, not UCS-2
3. There might be a bug in locale.cpp if it actually does UCS-2 -> UTF-8 conversion and Windows no longer uses UCS-2 (though I think they overlap for a lot of code-points)

@compnerd _LIBCPP_SHORT_WCHAR sounds good to me, especially in light of the front-end flag (didn't know that existed.)


Repository:
  rL LLVM

https://reviews.llvm.org/D28223