[PATCH] D28223: clean up use of _WIN32

Shoaib Meenai via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jan 3 10:48:00 PST 2017


smeenai added a comment.

In https://reviews.llvm.org/D28223#634199, @compnerd wrote:

> I figured that using the explicit encoding is nicer since it means that its more documenting.


I think @kimgr's point was that if you're using an explicit encoding, it should be UTF-16 rather than UCS-2 :)


Repository:
  rL LLVM

https://reviews.llvm.org/D28223





More information about the cfe-commits mailing list