[PATCH] D25686: [Driver] Improve support for Gentoo arm*-hardfloat-*-*eabi triples

[Renato Golin via Phabricator via cfe-commits]

rengolin added inline comments.


================
Comment at: lib/Driver/ToolChains.cpp:1674
       TripleAliases.append(begin(ARMHFTriples), end(ARMHFTriples));
+    } else if (TargetTriple.getEnvironment() == llvm::Triple::MuslEABIHF) {
+      TripleAliases.append(begin(ARMHFMuslTriples), end(ARMHFMuslTriples));
----------------
mgorny wrote:
> rengolin wrote:
> > You're not testing this...
> Well, I presumed I don't have to test every single possible triple. But sure, I can add a test for that.
You should test every new thing that you add.


================
Comment at: test/Driver/linux-ld.c:1016
+// CHECK-LD-GENTOO-ARMHF: "-dynamic-linker" "/lib/ld-linux-armhf.so.3"
+// CHECK-LD-GENTOO-ARMHF: "{{.*}}/usr/lib/gcc/armv7a-hardfloat-linux-gnueabi/4.9.3/crtbegin.o"
+// CHECK-LD-GENTOO-ARMHF: "-L[[SYSROOT]]/usr/lib/gcc/armv7a-hardfloat-linux-gnueabi/4.9.3"
----------------
mgorny wrote:
> rengolin wrote:
> > where is 4.9.3 coming from?
> It's the version used in the input tree, i.e. the two added files above.
Right, I mean is this "4.9.3" there because the driver "found" it there, or is it generated by the compiler version you have on your machine, and that's why you created the directory with "4.9.3" in it?

I'm worried that if it's the latter, the test will fail on any machine that doesn't have that compiler version. But I really don't know how it works, so it was an honest question. :)


https://reviews.llvm.org/D25686