[PATCH] D25686: [Driver] Improve support for Gentoo arm*-hardfloat-*-*eabi triples

[Michał Górny via Phabricator via cfe-commits]

mgorny added inline comments.


================
Comment at: lib/Driver/ToolChains.cpp:1674
       TripleAliases.append(begin(ARMHFTriples), end(ARMHFTriples));
+    } else if (TargetTriple.getEnvironment() == llvm::Triple::MuslEABIHF) {
+      TripleAliases.append(begin(ARMHFMuslTriples), end(ARMHFMuslTriples));
----------------
rengolin wrote:
> You're not testing this...
Well, I presumed I don't have to test every single possible triple. But sure, I can add a test for that.


================
Comment at: test/Driver/linux-ld.c:1016
+// CHECK-LD-GENTOO-ARMHF: "-dynamic-linker" "/lib/ld-linux-armhf.so.3"
+// CHECK-LD-GENTOO-ARMHF: "{{.*}}/usr/lib/gcc/armv7a-hardfloat-linux-gnueabi/4.9.3/crtbegin.o"
+// CHECK-LD-GENTOO-ARMHF: "-L[[SYSROOT]]/usr/lib/gcc/armv7a-hardfloat-linux-gnueabi/4.9.3"
----------------
rengolin wrote:
> where is 4.9.3 coming from?
It's the version used in the input tree, i.e. the two added files above.


https://reviews.llvm.org/D25686