[PATCH] D27138: Extend CompilationDatabase by a field for the output filename

Joerg Sonnenberger via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Nov 28 04:08:57 PST 2016


joerg added inline comments.


================
Comment at: lib/Tooling/JSONCompilationDatabase.cpp:266
+        nodeToCommandLine(Syntax, std::get<2>(CommandsRef[I])),
+        Output ? Output->getValue(OutputStorage) : "");
   }
----------------
klimek wrote:
> Optional: I'd probably let the nodeToCommandLine handle the null value and make this code more straight forward?
I couldn't find a way to create a synthetic node without changing the YAML API.


Repository:
  rL LLVM

https://reviews.llvm.org/D27138





More information about the cfe-commits mailing list