[PATCH] D27138: Extend CompilationDatabase by a field for the output filename

Manuel Klimek via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Nov 28 01:57:49 PST 2016


klimek added inline comments.


================
Comment at: lib/Tooling/JSONCompilationDatabase.cpp:266
+        nodeToCommandLine(Syntax, std::get<2>(CommandsRef[I])),
+        Output ? Output->getValue(OutputStorage) : "");
   }
----------------
Optional: I'd probably let the nodeToCommandLine handle the null value and make this code more straight forward?


Repository:
  rL LLVM

https://reviews.llvm.org/D27138





More information about the cfe-commits mailing list