[PATCH] D25985: [analyzer] Export coverage information from the analyzer.

[Anna Zaks via cfe-commits]

zaks.anna added inline comments.


================
Comment at: lib/StaticAnalyzer/Core/ExprEngine.cpp:262
+
+static void dumpCoverageInfo(llvm::SmallVectorImpl<char> &Path,
+                             SourceManager &SM) {
----------------
xazax.hun wrote:
> zaks.anna wrote:
> > xazax.hun wrote:
> > > zaks.anna wrote:
> > > > Can this be a debug checker?
> > > You mean the dumping part or also collecting the coverage? It can be a debug checker if we add a new callback like "checkBasicBlockBegin". I did not want to add such callback just for a debug check. However, it is possible to move only the dumping part to a separate checker. What would you prefer?
> > I would prefer to add a "checkBasicBlockBegin" callback and move all of this diagnostic code into a debug checker. 
> Do you think the checkers should be able to add state transitions from BeginBasicBlock callback? Would you prefer to have an EndBasicBlock callback for symmetry?
I cannot think of any right now. The main advantages of having this as a debug checker are:
 - Not having this code in ExprEngine.cpp - it's not related to the core engine functionality.
 - More importantly, discoverability of this functionality.

On the downside, we would not want to add a checker API if it has no useful users.



https://reviews.llvm.org/D25985