[PATCH] D25985: [analyzer] Export coverage information from the analyzer.

[Gábor Horváth via cfe-commits]

xazax.hun added inline comments.


================
Comment at: lib/StaticAnalyzer/Core/ExprEngine.cpp:262
+
+static void dumpCoverageInfo(llvm::SmallVectorImpl<char> &Path,
+                             SourceManager &SM) {
----------------
zaks.anna wrote:
> xazax.hun wrote:
> > zaks.anna wrote:
> > > Can this be a debug checker?
> > You mean the dumping part or also collecting the coverage? It can be a debug checker if we add a new callback like "checkBasicBlockBegin". I did not want to add such callback just for a debug check. However, it is possible to move only the dumping part to a separate checker. What would you prefer?
> I would prefer to add a "checkBasicBlockBegin" callback and move all of this diagnostic code into a debug checker. 
Do you think the checkers should be able to add state transitions from BeginBasicBlock callback? Would you prefer to have an EndBasicBlock callback for symmetry?


https://reviews.llvm.org/D25985