[PATCH] D26268: [CUDA] Use only the GVALinkage on function definitions.

[Justin Lebar via cfe-commits]

jlebar marked 2 inline comments as done.
jlebar added a comment.

Thank you for the review!  Submitting...



================
Comment at: clang/test/SemaCUDA/add-inline-in-definition.cu:13-14
+//
+// The trickiness here comes from the fact that the FunctionDecl bar() sees for
+// foo() does not have the "inline" keyword, so we might incorrectly think that
+// foo() is a priori known-emitted.  This would prevent us from marking foo()
----------------
tra wrote:
> "bar() sees for foo()" does not sound right. Did you mean "bar() sees *that* foo()"?
Yes, this is a mistake, thanks!


================
Comment at: clang/test/SemaCUDA/add-inline-in-definition.cu:15
+// foo() does not have the "inline" keyword, so we might incorrectly think that
+// foo() is a priori known-emitted.  This would prevent us from marking foo()
+// as known-emitted, which would prevent us from emitting an error for foo()'s
----------------
tra wrote:
> Extra whitespace.
We seem to be pretty evenly-split wrt one or two spaces here in llvm, agreed irl it's nbd.


https://reviews.llvm.org/D26268