[PATCH] D26268: [CUDA] Use only the GVALinkage on function definitions.

[Artem Belevich via cfe-commits]

tra accepted this revision.
tra added a comment.
This revision is now accepted and ready to land.

LGTM.



================
Comment at: clang/test/SemaCUDA/add-inline-in-definition.cu:13-14
+//
+// The trickiness here comes from the fact that the FunctionDecl bar() sees for
+// foo() does not have the "inline" keyword, so we might incorrectly think that
+// foo() is a priori known-emitted.  This would prevent us from marking foo()
----------------
"bar() sees for foo()" does not sound right. Did you mean "bar() sees *that* foo()"?


================
Comment at: clang/test/SemaCUDA/add-inline-in-definition.cu:15
+// foo() does not have the "inline" keyword, so we might incorrectly think that
+// foo() is a priori known-emitted.  This would prevent us from marking foo()
+// as known-emitted, which would prevent us from emitting an error for foo()'s
----------------
Extra whitespace.


https://reviews.llvm.org/D26268