[libcxx] r285456 - Added 'inline' attribute to basic_string's destructor

[Mehdi Amini via cfe-commits]

Hi Adtiya,

I had to revert in r285485 to unbreak this build bot: http://lab.llvm.org:8080/green/job/clang-stage2-configure-Rlto_build/10737/ <http://lab.llvm.org:8080/green/job/clang-stage2-configure-Rlto_build/10737/>
(LTO bootstrap of clang).

Let’s iterate on the revision on Phabricator to figure out what it the right fix!

Best,

— 
Mehdi


> On Oct 28, 2016, at 2:27 PM, Aditya Kumar via cfe-commits <cfe-commits at lists.llvm.org> wrote:
> 
> Author: hiraditya
> Date: Fri Oct 28 16:27:24 2016
> New Revision: 285456
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=285456&view=rev
> Log:
> Added 'inline' attribute to basic_string's destructor
> 
> Author: laxmansole
> 
> Reviewers: howard.hinnant
>           mclow.lists
> Subscribers: EricWF, flyingforyou, evandro
> 
> Differential Revision: https://reviews.llvm.org/D25624
> 
> Reapplying the patch as the bug https://llvm.org/bugs/show_bug.cgi?id=30341 is fixed.
> 
> Currently basic_string's destructor is not getting inlined. So adding 'inline' attribute to ~basic_string().
> Worked in collaboration with Aditya Kumar.
> 
> Modified:
>    libcxx/trunk/include/string
> 
> Modified: libcxx/trunk/include/string
> URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/include/string?rev=285456&r1=285455&r2=285456&view=diff
> ==============================================================================
> --- libcxx/trunk/include/string (original)
> +++ libcxx/trunk/include/string Fri Oct 28 16:27:24 2016
> @@ -806,6 +806,7 @@ public:
>     basic_string(initializer_list<value_type> __il, const allocator_type& __a);
> #endif  // _LIBCPP_HAS_NO_GENERALIZED_INITIALIZERS
> 
> +    inline _LIBCPP_EXTERN_TEMPLATE_INLINE_VISIBILITY
>     ~basic_string();
> 
>     _LIBCPP_INLINE_VISIBILITY
> 
> 
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20161028/bce07095/attachment.html>