<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">Hi Adtiya,<div class=""><br class=""></div><div class="">I had to revert in r285485 to unbreak this build bot: <a href="http://lab.llvm.org:8080/green/job/clang-stage2-configure-Rlto_build/10737/" class="">http://lab.llvm.org:8080/green/job/clang-stage2-configure-Rlto_build/10737/</a></div><div class="">(LTO bootstrap of clang).</div><div class=""><br class=""></div><div class="">Let’s iterate on the revision on Phabricator to figure out what it the right fix!</div><div class=""><br class=""></div><div class="">Best,</div><div class=""><br class=""></div><div class="">— </div><div class="">Mehdi</div><div class=""><br class=""></div><div class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Oct 28, 2016, at 2:27 PM, Aditya Kumar via cfe-commits <<a href="mailto:cfe-commits@lists.llvm.org" class="">cfe-commits@lists.llvm.org</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div class="">Author: hiraditya<br class="">Date: Fri Oct 28 16:27:24 2016<br class="">New Revision: 285456<br class=""><br class="">URL: <a href="http://llvm.org/viewvc/llvm-project?rev=285456&view=rev" class="">http://llvm.org/viewvc/llvm-project?rev=285456&view=rev</a><br class="">Log:<br class="">Added 'inline' attribute to basic_string's destructor<br class=""><br class="">Author: laxmansole<br class=""><br class="">Reviewers: howard.hinnant<br class=""> mclow.lists<br class="">Subscribers: EricWF, flyingforyou, evandro<br class=""><br class="">Differential Revision: <a href="https://reviews.llvm.org/D25624" class="">https://reviews.llvm.org/D25624</a><br class=""><br class="">Reapplying the patch as the bug <a href="https://llvm.org/bugs/show_bug.cgi?id=30341" class="">https://llvm.org/bugs/show_bug.cgi?id=30341</a> is fixed.<br class=""><br class="">Currently basic_string's destructor is not getting inlined. So adding 'inline' attribute to ~basic_string().<br class="">Worked in collaboration with Aditya Kumar.<br class=""><br class="">Modified:<br class=""> libcxx/trunk/include/string<br class=""><br class="">Modified: libcxx/trunk/include/string<br class="">URL: <a href="http://llvm.org/viewvc/llvm-project/libcxx/trunk/include/string?rev=285456&r1=285455&r2=285456&view=diff" class="">http://llvm.org/viewvc/llvm-project/libcxx/trunk/include/string?rev=285456&r1=285455&r2=285456&view=diff</a><br class="">==============================================================================<br class="">--- libcxx/trunk/include/string (original)<br class="">+++ libcxx/trunk/include/string Fri Oct 28 16:27:24 2016<br class="">@@ -806,6 +806,7 @@ public:<br class=""> basic_string(initializer_list<value_type> __il, const allocator_type& __a);<br class=""> #endif // _LIBCPP_HAS_NO_GENERALIZED_INITIALIZERS<br class=""><br class="">+ inline _LIBCPP_EXTERN_TEMPLATE_INLINE_VISIBILITY<br class=""> ~basic_string();<br class=""><br class=""> _LIBCPP_INLINE_VISIBILITY<br class=""><br class=""><br class="">_______________________________________________<br class="">cfe-commits mailing list<br class=""><a href="mailto:cfe-commits@lists.llvm.org" class="">cfe-commits@lists.llvm.org</a><br class="">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits<br class=""></div></div></blockquote></div><br class=""></div></body></html>