[PATCH] D25624: Added 'inline' attribute to basic_string's destructor

[Sebastian Pop via cfe-commits]

sebpop added a comment.

Other than removing that comment the patch looks good.
Thanks!



================
Comment at: libcxx/src/string.cpp:10
 
+// For keeping the definition of ~basic_string in this translation unit.
+#define _LIBCPP_BUILDING_STRING
----------------
Let's not add this comment here, as this define may be used in the future for other purposes.  Also a simple grep would give you the places where this is used.


https://reviews.llvm.org/D25624