[PATCH] D25624: Added 'inline' attribute to basic_string's destructor

[Aditya Kumar via cfe-commits]

hiraditya updated this revision to Diff 76192.
hiraditya added a comment.

Addressed Sebastian's comments.


https://reviews.llvm.org/D25624

Files:
  libcxx/include/string
  libcxx/src/string.cpp


Index: libcxx/src/string.cpp
===================================================================
--- libcxx/src/string.cpp
+++ libcxx/src/string.cpp
@@ -7,6 +7,9 @@
 //
 //===----------------------------------------------------------------------===//
 
+// For keeping the definition of ~basic_string in this translation unit.
+#define _LIBCPP_BUILDING_STRING
+
 #include "string"
 #include "cstdlib"
 #include "cwchar"
Index: libcxx/include/string
===================================================================
--- libcxx/include/string
+++ libcxx/include/string
@@ -1834,6 +1834,9 @@
 #endif  // _LIBCPP_HAS_NO_GENERALIZED_INITIALIZERS
 
 template <class _CharT, class _Traits, class _Allocator>
+#ifndef _LIBCPP_BUILDING_STRING
+inline _LIBCPP_INLINE_VISIBILITY
+#endif
 basic_string<_CharT, _Traits, _Allocator>::~basic_string()
 {
 #if _LIBCPP_DEBUG_LEVEL >= 2


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D25624.76192.patch
Type: text/x-patch
Size: 871 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20161028/366dac8d/attachment.bin>