[PATCH] D25678: [modules] Do not report missing definitions of demoted constexpr variable templates.This is a followup to regression introduced in r284284.This should fix our libstdc++ modules builds.
Vassil Vassilev via cfe-commits
cfe-commits at lists.llvm.org
Tue Oct 18 01:08:08 PDT 2016
v.g.vassilev added inline comments.
================
Comment at: lib/Sema/SemaDecl.cpp:10129
+ !Var->isThisDeclarationADemotedDefinition()) {
+ assert(Var->isThisDeclarationADemotedDefinition() && getLangOpts().Modules
+ && "Demoting decls is only in the contest of modules!");
----------------
manmanren wrote:
> Is the logic correct here? The if statement says !Var->isThisDeclarationADemotedDefinition(), and we then assert Var->isThisDeclarationADemotedDefinition() && getLangOpts().Modules.
Oops, that is an old version of the patch. Uploading the new one.
https://reviews.llvm.org/D25678
More information about the cfe-commits
mailing list