[PATCH] D25204: Register Calling Convention, Clang changes

David Majnemer via cfe-commits cfe-commits at lists.llvm.org
Tue Oct 4 11:01:20 PDT 2016


majnemer added inline comments.


> ItaniumMangle.cpp:1234
>  
> -      mangleSourceName(II);
> +      auto FD = dyn_cast<FunctionDecl>(ND);
> +      bool isRegCall = (FD != nullptr) &&

`auto *`

> ItaniumMangle.cpp:1235
> +      auto FD = dyn_cast<FunctionDecl>(ND);
> +      bool isRegCall = (FD != nullptr) &&
> +        FD->getType()->castAs<FunctionType>()->getCallConv() ==

The convention is to just do `FD` instead of `(FD != nullptr)`

https://reviews.llvm.org/D25204





More information about the cfe-commits mailing list