[PATCH] D25204: Register Calling Convention, Clang changes

[David Majnemer via cfe-commits]

majnemer added inline comments.


> ItaniumMangle.cpp:1413-1414
>  
> -void CXXNameMangler::mangleSourceName(const IdentifierInfo *II) {
> -  // <source-name> ::= <positive length number> <identifier>
> +void CXXNameMangler::mangleSourceName(const IdentifierInfo *II,
> +                                      bool isRegCall) {
> +  // <source-name> ::= <positive length number> [__regcall3__] <identifier>

I'd add an overload of `mangleSourceName` which takes a `Twine`. Then the one caller which passes `isRegCall` would merely concat the identifier with __regcall3__. The existing implementation using `IdentifierInfo` would merely pass in `II->getName` for the `Twine`.

https://reviews.llvm.org/D25204