[PATCH] D22507: Clang-tidy - Enum misuse check

Peter Szecsi via cfe-commits cfe-commits at lists.llvm.org
Fri Sep 30 15:56:06 PDT 2016


szepet added inline comments.


> alexfh wrote in SuspiciousEnumUsageCheck.cpp:155
> Why?

Because the hasDisjointValueRange function could not decide the values properly. So in case of an empty Enum it would not make sense. Fortunately we know that the empty case should not be reported so used early return on this.

That is why this is needed if we want a deterministic check.

https://reviews.llvm.org/D22507





More information about the cfe-commits mailing list