[PATCH] D22507: Clang-tidy - Enum misuse check

Peter Szecsi via cfe-commits cfe-commits at lists.llvm.org
Fri Sep 30 15:48:42 PDT 2016


szepet updated this revision to Diff 73157.
szepet marked 13 inline comments as done.
szepet added a comment.

Updates based on comments (the testfile note comments will be added in the next commit)

Some changes in the algorithm/design:
In non-strict mode the checker will only investigate the operations between different enum types.
In strict mode we check the suspicious bitmasks too.
(In the previous comments we always talked about only the strict mode heuristics and looked on the strict results. )


https://reviews.llvm.org/D22507

Files:
  clang-tidy/misc/CMakeLists.txt
  clang-tidy/misc/MiscTidyModule.cpp
  clang-tidy/misc/SuspiciousEnumUsageCheck.cpp
  clang-tidy/misc/SuspiciousEnumUsageCheck.h
  docs/clang-tidy/checks/list.rst
  docs/clang-tidy/checks/misc-suspicious-enum-usage.rst
  test/clang-tidy/misc-suspicious-enum-usage-strict.cpp
  test/clang-tidy/misc-suspicious-enum-usage.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D22507.73157.patch
Type: text/x-patch
Size: 19417 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20160930/6c944ef6/attachment-0001.bin>


More information about the cfe-commits mailing list