[PATCH] D24648: Fix unused result from sign extending an Offset.

David Majnemer via cfe-commits cfe-commits at lists.llvm.org
Thu Sep 15 23:45:03 PDT 2016


sext should probably be marked WARN_UNUSED_RESULT

On Thursday, September 15, 2016, Stephen Hines via cfe-commits <
cfe-commits at lists.llvm.org> wrote:

> srhines created this revision.
> srhines added a reviewer: cfe-commits.
> srhines added a subscriber: meikeb.
>
> Offset was doubled in size, but the assignment was missing. We just need
> to reassign to the original variable in this case to fix it.
>
> https://reviews.llvm.org/D24648
>
> Files:
>   lib/Sema/SemaChecking.cpp
>
> Index: lib/Sema/SemaChecking.cpp
> ===================================================================
> --- lib/Sema/SemaChecking.cpp
> +++ lib/Sema/SemaChecking.cpp
> @@ -3882,7 +3882,7 @@
>    // possible.
>    if (Ov) {
>      assert(BitWidth <= UINT_MAX / 2 && "index (intermediate) result too
> big");
> -    Offset.sext(2 * BitWidth);
> +    Offset = Offset.sext(2 * BitWidth);
>      sumOffsets(Offset, Addend, BinOpKind, AddendIsRight);
>      return;
>    }
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20160915/4f2d3781/attachment.html>


More information about the cfe-commits mailing list