sext should probably be marked WARN_UNUSED_RESULT<span></span><br><br>On Thursday, September 15, 2016, Stephen Hines via cfe-commits <<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a>> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">srhines created this revision.<br>
srhines added a reviewer: cfe-commits.<br>
srhines added a subscriber: meikeb.<br>
<br>
Offset was doubled in size, but the assignment was missing. We just need<br>
to reassign to the original variable in this case to fix it.<br>
<br>
<a href="https://reviews.llvm.org/D24648" target="_blank">https://reviews.llvm.org/<wbr>D24648</a><br>
<br>
Files:<br>
  lib/Sema/SemaChecking.cpp<br>
<br>
Index: lib/Sema/SemaChecking.cpp<br>
==============================<wbr>==============================<wbr>=======<br>
--- lib/Sema/SemaChecking.cpp<br>
+++ lib/Sema/SemaChecking.cpp<br>
@@ -3882,7 +3882,7 @@<br>
   // possible.<br>
   if (Ov) {<br>
     assert(BitWidth <= UINT_MAX / 2 && "index (intermediate) result too big");<br>
-    Offset.sext(2 * BitWidth);<br>
+    Offset = Offset.sext(2 * BitWidth);<br>
     sumOffsets(Offset, Addend, BinOpKind, AddendIsRight);<br>
     return;<br>
   }<br>
<br>
<br>
</blockquote>