[PATCH] D24599: Add 'inline' but not _LIBCPP_INLINE_VISIBILITY to basic_string's destructor

[Aditya Kumar via cfe-commits]

hiraditya added a comment.

@EricWF, since inline is only a hint, the compiler would not inline in many cases, it might give the inliner a little bit of push to inline. When we were working on this patch, adding inline wasn't enough and hence we added the _LIBCPP_INLINE_VISIBILITY flag. The compiler crash seems to be in the Verifier which does not allow aliases to available_externally functions.


https://reviews.llvm.org/D24599