[PATCH] D23492: Make function local tags visible.

[Richard Smith via cfe-commits]

rsmith added a comment.

Should be fixed in r279486, which also incorporates the updates to this change since it landed (sinking diagnostics into `DiagnoseUninstantiableTemplate`).


================
Comment at: lib/Sema/SemaTemplate.cpp:494-495
@@ +493,4 @@
+    // Say nothing
+  }
+  else if (FunctionDecl *FD = dyn_cast<FunctionDecl>(Instantiation)) {
+    if (!PatternDef) {
----------------
`}` and `else` on the same line please. (Here and in a couple of places below.)

================
Comment at: lib/Sema/SemaTemplate.cpp:499-501
@@ +498,5 @@
+        if (FD->getPrimaryTemplate())
+          Diag(PointOfInstantiation,
+               diag::err_explicit_instantiation_undefined_func_template)
+            << FD->getPrimaryTemplate();
+        else
----------------
Sink this into the `err_template_instantiate_undefined` case below.

================
Comment at: lib/Sema/SemaTemplate.cpp:503-505
@@ +502,5 @@
+        else
+          Diag(PointOfInstantiation,
+               diag::err_explicit_instantiation_undefined_member)
+            << 1 << FD->getDeclName() << FD->getDeclContext();
+
----------------
Sink this into the `InstantiatedFromMember` case below.


https://reviews.llvm.org/D23492