[PATCH] D23492: Make function local tags visible.

[Vassil Vassilev via cfe-commits]

v.g.vassilev added inline comments.

================
Comment at: lib/Sema/SemaTemplateInstantiateDecl.cpp:3617
@@ +3616,3 @@
+    PatternDef = nullptr;
+  // FIXME: We need to track the instantiation stack in order to know which
+  // definitions should be visible within this instantiation.
----------------
akuegel wrote:
> v.g.vassilev wrote:
> > akuegel wrote:
> > > Line 3619 to 3623 breaks the compilation of some of our targets. I am not sure if it is because of a mistake in our code or if there is something bad in this patch.
> > > This comment seems to indicate that there is still something missing to make the check here correct?
> > @akuegel, would you be able to reduce a standalone example?
> I tried to create a simple example, but those simple cases worked fine. So I am not sure what is going on in the more complex cases. I have asked Richard for help. Since Richard has access to that broken code, I hope he will figure it out.
Thanks! Otherwise, maybe `creduce` could help.


https://reviews.llvm.org/D23492