[PATCH] D23643: [Driver] Report invalid -mtune/-mcpu parameters when -arch=arm64

Vedant Kumar via cfe-commits cfe-commits at lists.llvm.org
Thu Aug 18 11:17:20 PDT 2016


vsk added inline comments.

================
Comment at: lib/Driver/Tools.cpp:1163
@@ -1162,3 +1162,3 @@
   // FIXME: Should this be picked by checking the target triple instead?
-  if (Args.getLastArg(options::OPT_arch))
+  if ((A = Args.getLastArg(options::OPT_arch)))
     return "cyclone";
----------------
ahatanak wrote:
> Is there a test case for this change? I don't think this was needed to pass the tests you added?
Good point, I'll work up a test case.


https://reviews.llvm.org/D23643





More information about the cfe-commits mailing list