[PATCH] D23643: [Driver] Report invalid -mtune/-mcpu parameters when -arch=arm64

Akira Hatanaka via cfe-commits cfe-commits at lists.llvm.org
Thu Aug 18 11:15:31 PDT 2016


ahatanak added a subscriber: ahatanak.
ahatanak added a comment.

Thanks Vedant, this also fixes the crash that occurs when -mtune=native is provided.

https://reviews.llvm.org/D14471.


================
Comment at: lib/Driver/Tools.cpp:1163
@@ -1162,3 +1162,3 @@
   // FIXME: Should this be picked by checking the target triple instead?
-  if (Args.getLastArg(options::OPT_arch))
+  if ((A = Args.getLastArg(options::OPT_arch)))
     return "cyclone";
----------------
Is there a test case for this change? I don't think this was needed to pass the tests you added?


https://reviews.llvm.org/D23643





More information about the cfe-commits mailing list