[PATCH] D19770: Add FixedSizeStorage to TrailingObjects; NFC

[Hubert Tong via cfe-commits]

On Fri, Jun 24, 2016 at 3:07 PM, Aaron Ballman <aaron.ballman at gmail.com>
wrote:

> On Fri, Jun 24, 2016 at 8:05 AM, Hubert Tong
> <hubert.reinterpretcast at gmail.com> wrote:
> > On Fri, Jun 24, 2016 at 3:00 PM, Aaron Ballman <aaron.ballman at gmail.com>
> > wrote:
> >>
> >> aaron.ballman added a comment.
> >>
> >> Did Richard sign off on this off-line? Also, this has caused a bot
> >> failure:
> >
> > That was my understanding.
>
> Ah, I meant, "I approve this, but wait for Richard to explicitly
> approve before committing." I'm sorry if I didn't make that clear
> enough! If Richard okayed it offline with you, that's fine (but he
> should also sign off in phab, or post a comment) so everyone following
> the thread knows.
>
I meant that my understanding is that Richard has okayed it offline.
As for the bot failure, it appears it applies local patches to avoid
compiler bugs.
I am not sure what the policy is if a bot failure has more to do with the
bot set-up than the change (assuming that is the case here).
In any case, I am not sure I can resolve the failure without cooperation
from the bot owner.

-- HT


>
> ~Aaron
>
> >
> >>
> >>
> >> 7:57 AM <bb-chapuni> build #4390 of ninja-clang-i686-msc19-R is
> complete:
> >> Failure [failed build_clang_tools_1]  Build details are at
> >> http://bb.pgr.jp/builders/ninja-clang-i686-msc19-R/builds/4390
> blamelist:
> >> Hubert Tong <hubert.reinterpretcast at gmail.com>
> >>
> >>
> >> http://reviews.llvm.org/D19770
> >>
> >>
> >>
> >
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20160624/a362ddab/attachment.html>