[PATCH] D19770: Add FixedSizeStorage to TrailingObjects; NFC

Aaron Ballman via cfe-commits cfe-commits at lists.llvm.org
Fri Jun 24 05:07:57 PDT 2016


On Fri, Jun 24, 2016 at 8:05 AM, Hubert Tong
<hubert.reinterpretcast at gmail.com> wrote:
> On Fri, Jun 24, 2016 at 3:00 PM, Aaron Ballman <aaron.ballman at gmail.com>
> wrote:
>>
>> aaron.ballman added a comment.
>>
>> Did Richard sign off on this off-line? Also, this has caused a bot
>> failure:
>
> That was my understanding.

Ah, I meant, "I approve this, but wait for Richard to explicitly
approve before committing." I'm sorry if I didn't make that clear
enough! If Richard okayed it offline with you, that's fine (but he
should also sign off in phab, or post a comment) so everyone following
the thread knows.

~Aaron

>
>>
>>
>> 7:57 AM <bb-chapuni> build #4390 of ninja-clang-i686-msc19-R is complete:
>> Failure [failed build_clang_tools_1]  Build details are at
>> http://bb.pgr.jp/builders/ninja-clang-i686-msc19-R/builds/4390  blamelist:
>> Hubert Tong <hubert.reinterpretcast at gmail.com>
>>
>>
>> http://reviews.llvm.org/D19770
>>
>>
>>
>


More information about the cfe-commits mailing list