[PATCH] D19274: Compilation for Intel MCU (Part 2/3)

Andrey Turetskiy via cfe-commits cfe-commits at lists.llvm.org
Thu May 26 05:23:14 PDT 2016


aturetsk added inline comments.

================
Comment at: lib/Driver/Tools.cpp:3657
@@ +3656,3 @@
+  if (IsIAMCU && types::isCXX(Input.getType()))
+    D.Diag(diag::err_drv_cxx_not_supported) << getToolChain().getTriple().str();
+
----------------
bruno wrote:
> Taking a look at this again I don't think there's a real need for a new diagnostic here; instead of adding diag::err_drv_cxx_not_supported, you can do something similar to:
> 
> D.Diag(diag::err_drv_clang_unsupported) << "C++ is not supported with -miamcu"
> 
> Otherwise, LGTM!
The best thing I could come up with is this:
```
D.Diag(diag::err_drv_clang_unsupported) << "C++ for IAMCU";
```
This code makes the error message look like this:
```
error: the clang compiler does not support 'C++ for IAMCU'
```
As you can see the message is a bit crooked. Do you thinks it's better to keep it this way?


http://reviews.llvm.org/D19274





More information about the cfe-commits mailing list