[PATCH] D19274: Compilation for Intel MCU (Part 2/3)

Bruno Cardoso Lopes via cfe-commits cfe-commits at lists.llvm.org
Wed May 25 11:06:31 PDT 2016


bruno added a comment.

Hi,


================
Comment at: lib/Driver/Tools.cpp:3657
@@ +3656,3 @@
+  if (IsIAMCU && types::isCXX(Input.getType()))
+    D.Diag(diag::err_drv_cxx_not_supported) << getToolChain().getTriple().str();
+
----------------
Taking a look at this again I don't think there's a real need for a new diagnostic here; instead of adding diag::err_drv_cxx_not_supported, you can do something similar to:

D.Diag(diag::err_drv_clang_unsupported) << "C++ is not supported with -miamcu"

Otherwise, LGTM!


http://reviews.llvm.org/D19274





More information about the cfe-commits mailing list