[PATCH] D19175: Fix for PR27015 (variable template initialized with a generic lambda expression)

Akira Hatanaka via cfe-commits cfe-commits at lists.llvm.org
Fri Apr 29 11:07:28 PDT 2016


If I add an assert to check (F != Flags) in setFlags, 2700+ out of 5000+ clang regression tests fail. I haven’t figured out which parts of clang are passing the same value to setFlags.

> On Apr 28, 2016, at 7:38 PM, Richard Smith via cfe-commits <cfe-commits at lists.llvm.org> wrote:
> 
> On Thu, Apr 28, 2016 at 7:34 PM, Akira Hatanaka via cfe-commits <cfe-commits at lists.llvm.org <mailto:cfe-commits at lists.llvm.org>> wrote:
> ahatanak added a comment.
> 
> Thanks for the review. I committed the patch in r267956 and r267975.
> 
> Do you think I should make setFlags(unsigned F) return early if F == Flags?
> 
> I don't think that should happen in practice, so it doesn't seem worth checking.
> 
> Repository:
>   rL LLVM
> 
> http://reviews.llvm.org/D19175 <http://reviews.llvm.org/D19175>
> 
> 
> 
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at lists.llvm.org <mailto:cfe-commits at lists.llvm.org>
> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits <http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits>
> 
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20160429/86382d51/attachment.html>


More information about the cfe-commits mailing list