<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><div class="">If I add an assert to check (F != Flags) in setFlags, 2700+ out of 5000+ clang regression tests fail. I haven’t figured out which parts of clang are passing the same value to setFlags.</div><br class=""><div><blockquote type="cite" class=""><div class="">On Apr 28, 2016, at 7:38 PM, Richard Smith via cfe-commits <<a href="mailto:cfe-commits@lists.llvm.org" class="">cfe-commits@lists.llvm.org</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class=""><div class="gmail_extra"><div class="gmail_quote">On Thu, Apr 28, 2016 at 7:34 PM, Akira Hatanaka via cfe-commits <span dir="ltr" class=""><<a href="mailto:cfe-commits@lists.llvm.org" target="_blank" class="">cfe-commits@lists.llvm.org</a>></span> wrote:<br class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">ahatanak added a comment.<br class="">
<br class="">
Thanks for the review. I committed the patch in r267956 and r267975.<br class="">
<br class="">
Do you think I should make setFlags(unsigned F) return early if F == Flags?</blockquote><div class=""><br class=""></div><div class="">I don't think that should happen in practice, so it doesn't seem worth checking.</div><div class=""><br class=""></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="im HOEnZb">
Repository:<br class="">
rL LLVM<br class="">
<br class="">
<a href="http://reviews.llvm.org/D19175" rel="noreferrer" target="_blank" class="">http://reviews.llvm.org/D19175</a><br class="">
<br class="">
<br class="">
<br class="">
</span><div class="HOEnZb"><div class="h5">_______________________________________________<br class="">
cfe-commits mailing list<br class="">
<a href="mailto:cfe-commits@lists.llvm.org" class="">cfe-commits@lists.llvm.org</a><br class="">
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank" class="">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br class="">
</div></div></blockquote></div><br class=""></div></div>
_______________________________________________<br class="">cfe-commits mailing list<br class=""><a href="mailto:cfe-commits@lists.llvm.org" class="">cfe-commits@lists.llvm.org</a><br class="">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits<br class=""></div></blockquote></div><br class=""></body></html>