[PATCH] D19679: Method pool in modules: sync up out of date selectors before writing the module

[Adrian Prantl via cfe-commits]

aprantl added inline comments.

================
Comment at: test/Modules/method_pool_write.m:3
@@ +2,3 @@
+// RUN: %clang_cc1 -fmodules-cache-path=%t -fmodules -fimplicit-module-maps -I %S/Inputs %s -verify
+// expected-no-diagnostics
+
----------------
manmanren wrote:
> aprantl wrote:
> > Is there anything meaningful that could be CHECKed in the output?
> This commit makes sure that we don't emit an error message for not being able to find the method. That is why it checks for no diagnostics. Maybe I should use -fsyntax-only?
Using -fsyntax-only and expected-no-diagnostics is fine, too. I was just wondering whether it might make sense (or is possible at all) to check that the method was indeed found in the emitted IR on top of that.


http://reviews.llvm.org/D19679