[PATCH] D19679: Method pool in modules: sync up out of date selectors before writing the module

[Manman Ren via cfe-commits]

manmanren added a comment.

Adrian,

Thanks for reviewing the patch!

Manman


================
Comment at: include/clang/Serialization/ASTReader.h:657
@@ +656,3 @@
+  /// Whether a selector is out of date. We mark a selector as out of date
+  // if we load another module after the method pool entry was pulled in.
+  llvm::DenseMap<Selector, bool> SelectorOutOfDate;
----------------
aprantl wrote:
> ///
Yes.

================
Comment at: test/Modules/method_pool_write.m:3
@@ +2,3 @@
+// RUN: %clang_cc1 -fmodules-cache-path=%t -fmodules -fimplicit-module-maps -I %S/Inputs %s -verify
+// expected-no-diagnostics
+
----------------
aprantl wrote:
> Is there anything meaningful that could be CHECKed in the output?
This commit makes sure that we don't emit an error message for not being able to find the method. That is why it checks for no diagnostics. Maybe I should use -fsyntax-only?


http://reviews.llvm.org/D19679