[PATCH] D18304: [DarwinDriver] Increase the number of valid digits for ld version string

Bruno Cardoso Lopes via cfe-commits cfe-commits at lists.llvm.org
Wed Mar 30 19:55:49 PDT 2016


bruno added a comment.

Committed r264987!


================
Comment at: lib/Driver/Driver.cpp:2549-2550
@@ +2548,4 @@
+  unsigned CurDigit = 0;
+  unsigned MaxDigits = Digits.size();
+  while (CurDigit < MaxDigits) {
+    unsigned Digit = (unsigned)strtol(Str, &End, 10);
----------------
rnk wrote:
> nit: Why not `CurDigit < Digits.size()`?
No specific reason. Done!


http://reviews.llvm.org/D18304





More information about the cfe-commits mailing list