[PATCH] D18304: [DarwinDriver] Increase the number of valid digits for ld version string

Reid Kleckner via cfe-commits cfe-commits at lists.llvm.org
Wed Mar 30 16:23:56 PDT 2016


rnk accepted this revision.
rnk added a reviewer: rnk.
rnk added a comment.
This revision is now accepted and ready to land.

lgtm, go for it


================
Comment at: lib/Driver/Driver.cpp:2549-2550
@@ +2548,4 @@
+  unsigned CurDigit = 0;
+  unsigned MaxDigits = Digits.size();
+  while (CurDigit < MaxDigits) {
+    unsigned Digit = (unsigned)strtol(Str, &End, 10);
----------------
nit: Why not `CurDigit < Digits.size()`?


http://reviews.llvm.org/D18304





More information about the cfe-commits mailing list