[PATCH] D18262: [clang-tidy] Skip reporting of not applicable fixes.

Alexander Kornienko via cfe-commits cfe-commits at lists.llvm.org
Fri Mar 18 07:17:19 PDT 2016


alexfh added a comment.

Thank you, Etienne!

Please add a regression test.


================
Comment at: ClangTidy.cpp:144
@@ -138,1 +143,3 @@
+       
+        Diag << FixItHint::CreateReplacement(Range, Fix.getReplacementText());
         ++TotalFixes;
----------------
aaron.ballman wrote:
> Is there a purpose to emitting the CreateReplacement if the fix isn't applicable?
No, I don't think we need a replacement with an invalid range.


http://reviews.llvm.org/D18262





More information about the cfe-commits mailing list